253 replies to this topic

[paulo ve]

yes, in many countries there trucks tank trucks that supply smaller, such as a tank that goes fast in the forest, and a large truck that does not enter or jamming in the mud, it would be more realistic in the game! Another good thing is that it would be acabace truck in the water tank and fill the small car combat fast!

[NathanDollinger]

So i have every thing working but!....

 

I can't get the supply line to un hook form the truck.... It all goes together fine but when the fires out and where cleaning up 

 

that craps stuck! 

 

any ideas?

 

 ( P.S. It shows the get in car icon instead of the unhook hose icon )

 

 

 

Edit.....! I got it to work! 

Thanks though!

Edited by NathanDollinger, 20 August 2013 - 10:14 AM.

[The Loot]

Okay, for setting up LA engines with hoses and cannon based on your two NYFD engines in the test.

 

Set type to GTF.

Have four connectors under the "superstructures" list (labeled "connector0-3"?).

For child-objects list, have a cannon (must be labeled "cannon"?), and then the connection named "water_supply". Also need an object named "controller", is that where the person put on top of the vehicle goes?

 

And then some semi-complicated script modifications afterwards.

[Hoppah]

Okay, for setting up LA engines with hoses and cannon based on your two NYFD engines in the test.

 

Set type to GTF.

Have four connectors under the "superstructures" list (labeled "connector0-3"?).

For child-objects list, have a cannon (must be labeled "cannon"?), and then the connection named "water_supply". Also need an object named "controller", is that where the person put on top of the vehicle goes?

 

And then some semi-complicated script modifications afterwards.

 

Correct, as for the water cannon, you also need an entirely invisible TLF vehicle with the water cannon superchild. That's the proto that spawns over the engine. Check out the folder Prototypes/Vehicles/06 Objects/ for the demo mod's example.

[paulo ve]

So i have every thing working but!....

 

I can't get the supply line to un hook form the truck.... It all goes together fine but when the fires out and where cleaning up 

 

that craps stuck! 

 

any ideas?

 

 ( P.S. It shows the get in car icon instead of the unhook hose icon )

 

 

 

Edit.....! I got it to work! 

Thanks though!

Try this!!

 

Spoiler

const char DUMMY_CHANGE[] = "DummyChange";

const char CMD_DUMMYATTACHFH[] = "DummyAttachFirehose";

const char CMD_DUMMYREMOVEFH[] = "DummyRemoveFirehose";

const char NAME_WATERCON[] = "hose_connection";

const char NAME_HYDRANT[] = "hydrant";

const char PROTO_FF[] = "mod:Prototypes/Persons/Feuerwehr/fwm.e4p";

const char PROTO_PA[] = "mod:Prototypes/Persons/Feuerwehr/fwm_pa.e4p";

const char DUMMY_HOSESON[] = "DummyHosesAreOn";

 

object RemoveFirehose2 : CommandScript

{

RemoveFirehose2()

{

                            SetIcon("install");

SetCursor("install");

SetValidTargets(ACTOR_PERSON|ACTOR_VEHICLE|ACTOR_OBJECT);

SetGroupID(CGROUP_FIREHOSE);

SetPriority(100);

}

 

bool CheckGroupVisibility(GameObject *Caller)

{

if(!Caller->IsValid() || Caller->GetType() != ACTOR_PERSON)

return false;

return (Caller->GetFirehoseID() != 0 || Caller->GetEquipment()==EQUIP_NONE);

}

 

bool CheckTarget(GameObject *Caller, Actor *Target, int childID)

{

if(!Caller->IsValid() || !Target->IsValid())

return false;

 

GameObject obj(Target);

if(Caller->GetEquipment()==EQUIP_NONE)

{

                        if (obj.GetType() == ACTOR_VEHICLE && obj.HasChild(NAME_WATERCON))

                           return true;

                        return false;

                }

 

if (Caller->GetEquipment()==EQUIP_FIREHOSE && Caller->GetType() == ACTOR_PERSON && Caller->GetFirehoseID() != 0)

{

if (Caller->GetID()==Target->GetID())

return true;

if (obj.GetType() == ACTOR_OBJECT && obj.IsHydrant() && obj.IsHydrantInUse() && (Caller->GetFirehoseID() == obj.GetFirehoseID()))

return true;

else if (obj.GetType() == ACTOR_VEHICLE)

{

Vehicle v(Target);

if (v.IsUsingConnector(Caller))

return true;

}

return false;

}

 

return false;

}

 

void PushActions(GameObject *Caller, Actor *Target, int childID)

{

                if(Caller->GetEquipment()==EQUIP_FIREHOSE)

{

    GameObject hydrant = Caller->GetHydrant();

    if (!hydrant.IsValid())

return;

    Vector TargetPos;

    if (hydrant.GetType() == ACTOR_OBJECT)

TargetPos = hydrant.GetTargetPoint(Caller, TARGET_FIREHOSE_HOOKUP);

    else if (hydrant.GetType() == ACTOR_VEHICLE)

    {

Vehicle v(&hydrant);

if (!v.GetUsedConnectorPosition(Caller, TargetPos))

return;

     }

     Person p(Caller);

     if (p.GetEnteredHouseID() != -1)

     {

   Actor ha = Game::GetActor(p.GetEnteredHouseID());

   OpenHouse sourceHouse(&ha);

   if (!sourceHouse.HasGroundEntrance() || sourceHouse.GetEntranceDoorID() == 0)

return false;

   int h0 = sourceHouse.GetID();

   Vector EntrancePos = sourceHouse.GetEntrancePosition(false);

   Actor house = Game::GetActor(h0);

   Caller->PushActionMove(ACTION_NEWLIST, EntrancePos, true);

   Caller->PushActionLeaveHouse(ACTION_APPEND, &house);

     }

 

Caller->PushActionMoveWithHose(ACTION_NEWLIST, TargetPos);

Caller->PushActionUseEquipment(ACTION_APPEND, &hydrant, childID, 10.0f);

if (hydrant.GetType() == ACTOR_VEHICLE && hydrant.HasCommand(DUMMY_HOSESON))

Caller->PushActionExecuteCommand(ACTION_APPEND, "AttachFireHose", &hydrant, 3, false);

                      else

                      {

                             char wstring[5];

                             snprintf(wstring, 5, "%s", hydrant.GetName());

                             if(wstring[0]!='v' || wstring[1]!='e' || wstring[2]!='r' || wstring[3]!='t')   

                             {

                                  //Caller->PushActionWait(ACTION_APPEND, 0.3f);

                                  Caller->PushActionExecuteCommand(ACTION_APPEND, CMD_DUMMYREMOVEFH, Target, 1, false);

                             }

 

                      }

                }

                else

                {

                       Vehicle v(Target);

                       Caller->PushActionMove(ACTION_NEWLIST, v.GetChildPosition(NAME_WATERCON));

                       Caller->PushActionExecuteCommand(ACTION_APPEND, CMD_DUMMYATTACHFH, Target, 3, false);

                }

}

};

 

object DummyRemoveFirehose : CommandScript

{

DummyRemoveFirehose()

{

}

 

bool CheckTarget(GameObject *Caller, Actor *Target, int childID)

{

}

 

void PushActions(GameObject *Caller, Actor *Target, int childID)

{

             if(childID == 0)

             {

                        if(Target->HasName(NAME_HYDRANT))

                        {

                             Vehicle s(Target);

                             if(s.GetNumUsedConnectors()==0)

                                 s.PushActionDeleteOwner(ACTION_NEWLIST);

                        }

                        Vector Pos;

                        float r[9];

                        Person p;

                        Person t(Caller);

                        Pos = Caller->GetPosition();

                        bool select = false;

                        Caller->GetRotation(r[0], r[1], r[2], r[3], r[4], r[5], r[6], r[7], r[8]);

               int PlayerID = Caller->GetPlayerMP();

               if(Caller->HasCommand(DUMMY_CHANGE))

               {

                   if(StrCompare(Caller->GetPrototypeFileName(), PROTO_PA)==0)

                      p = Game::CreatePerson(PROTO_FF, Caller->GetName());

                            if(StrCompare(Caller->GetPrototypeFileName(), PROTO_FF)==0)

                      p = Game::CreatePerson(PROTO_PA, Caller->GetName());

                        }

                        else

                            p = Game::CreatePerson(Caller->GetPrototypeFileName(), Caller->GetName());

                        if(Caller->IsSelected())

                              p.Select();

                        p.SetHealth(t.GetHealth());

                        Caller->PushActionDeleteOwner(ACTION_APPEND);

               p.SetPlayerMP(PlayerID);

               p.SetUpgradeLevel(3);

               p.SetEquipment(EQUIP_FIREHOSE);

                        p.SetPosition(Pos);

                        p.SetRotation(r[0], r[1], r[2], r[3], r[4], r[5], r[6], r[7], r[8]);

             }

             if(childID == 1)

             {

                        Caller->SetEquipment(EQUIP_NONE);

             }

             if(childID == 2)

             {

                        Person p(Caller);

                        p.RemoveObjectInRightHand();

             }

}

};

[NathanDollinger]

Correct, as for the water cannon, you also need an entirely invisible TLF vehicle with the water cannon superchild. That's the proto that spawns over the engine. Check out the folder Prototypes/Vehicles/06 Objects/ for the demo mod's example.

Will give this a shot!

[NathanDollinger]

Will give this a shot!

 

 

Okay, for setting up LA engines with hoses and cannon based on your two NYFD engines in the test.

 

Set type to GTF.

Have four connectors under the "superstructures" list (labeled "connector0-3"?).

For child-objects list, have a cannon (must be labeled "cannon"?), and then the connection named "water_supply". Also need an object named "controller", is that where the person put on top of the vehicle goes?

 

And then some semi-complicated script modifications afterwards.

 Okay so i tryed this out and got it working to the point of the fire fighter setting on the truck, the icons for cool and extinguish show up, and i believe the invisible vehicle shows up 

however i get no water flow nor will the script deactivate 

 

Thoughts?

[The Loot]

 Okay so i tryed this out and got it working to the point of the fire fighter setting on the truck, the icons for cool and extinguish show up, and i believe the invisible vehicle shows up 

however i get no water flow nor will the script deactivate 

 

Thoughts?

 

I'm in troubleshoot mode also.

 

My vehicle is set up just like the NY engines,, and I have an invisible vehicle set up for the switch command to use.

The water level looks to be activating on it correctly, as the 100% icon shows up, however pressing it does not bring up the message about water level, so something has to be wrong.

The waterswitch command activates, person ends up on top of vehicle, vehicle gains the cool and extinguish commands, but will not spray water. nor will it deactivate.

The rapiddeployment command activates, four people exit vehicle and grab hoses, one connects hose to hydrant and then to vehicle, but hoses cannot be attached to the vehicle, and there seems to be glitches with the people equipped with hoses (they don't have drop or attach/remove commands).

 

Here are my scripts.

 Command.rar   0bytes   38 downloads

[NathanDollinger]

I'm in troubleshoot mode also.

 

My vehicle is set up just like the NY engines,, and I have an invisible vehicle set up for the switch command to use.

The water level looks to be activating on it correctly, as the 100% icon shows up, however pressing it does not bring up the message about water level, so something has to be wrong.

The waterswitch command activates, person ends up on top of vehicle, vehicle gains the cool and extinguish commands, but will not spray water. nor will it deactivate.

The rapiddeployment command activates, four people exit vehicle and grab hoses, one connects hose to hydrant and then to vehicle, but hoses cannot be attached to the vehicle, and there seems to be glitches with the people equipped with hoses (they don't have drop or attach/remove commands).

 

Here are my scripts.

Command.rar

 

Well i have solved 75% of that so i will try to help!

Did you give the truck the water supply command in the editor ? If so thats wrong it should appear automatically!

You have water_supply_main as a object on your map?

You have supper structure prototypes for hose connections named connector0-3?

You have child-object names water_supply?

You have all engines set to GTF?

( The above is what would cause issues with the water level script showing up and giving the correct display along with any bug with the rapid deployment script such as not hooking to the truck, )

 

If your doing this with the LA mod 

You have water_supply_main as a object on your map?

You have supper structure prototypes for hose connections named connector0-3?

You have added attachfirehose command to personal in the editor?

You have deleted the LAEquipmentCommand.script ( For some reason this cause a issue )

You have also removed all Get(W/E).script other then the GetExtinguisher.script ( Also cause issue )

( Should fix bugs with FF's with hoses and hooking to truck! )

 

 

As for the Waterswitch script im stuck in the same spot as you! Hopefully hoppah will be kind and lend us some helpful advise! 

[Hoppah]

Yes, I can kind if I want to. 

 

To get the cannon to deactivate you will have to add a little 'fake' animation to the vehicle. Open the main .v3o file of the vehicle (fire_engine1.V3O / fire_engine2.V3O) and add the following at the bottom of the file:

M, activate0, 1
M, deactivate0, 1

That's all. The script uses the animation to check if the watercannon is either activated or not. The animation itself doesn't do anything visually, it's just another check.

 

Hereweard Fyning's WaterSwitch.script seems to look fine.

 

As for the disappearing attachhose/removehose commands. Open up LAEquipmentCommands.script and delete all lines that involve those 2 commands.

[The Loot]

Well i have solved 75% of that so i will try to help!

Did you give the truck the water supply command in the editor ? If so thats wrong it should appear automatically!

You have water_supply_main as a object on your map?

You have supper structure prototypes for hose connections named connector0-3?

You have child-object names water_supply?

You have all engines set to GTF?

( The above is what would cause issues with the water level script showing up and giving the correct display along with any bug with the rapid deployment script such as not hooking to the truck, )

 

If your doing this with the LA mod 

You have water_supply_main as a object on your map?

You have supper structure prototypes for hose connections named connector0-3?

You have added attachfirehose command to personal in the editor?

You have deleted the LAEquipmentCommand.script ( For some reason this cause a issue )

You have also removed all Get(W/E).script other then the GetExtinguisher.script ( Also cause issue )

( Should fix bugs with FF's with hoses and hooking to truck! )

 

 

As for the Waterswitch script im stuck in the same spot as you! Hopefully hoppah will be kind and lend us some helpful advise! 

 

Vehicle doesn't have command in editor, so that's fine.

A "water_supply_main" object was placed on map.

Four superstruct connectors named connector0-3, and child "water_supply", yep.

Vehicle type set to GTF, yep.

As for the equipment command, Hoppah had an idea...

I guess I need to add the attach command (remove also?).

 

Yes, I can kind if I want to. 

 

To get the cannon to deactivate you will have to add a little 'fake' animation to the vehicle. Open the main .v3o file of the vehicle (fire_engine1.V3O / fire_engine2.V3O) and add the following at the bottom of the file:

M, activate0, 1
M, deactivate0, 1

That's all. The script uses the animation to check if the watercannon is either activated or not. The animation itself doesn't do anything visually, it's just another check.

 

Hereweard Fyning's WaterSwitch.script seems to look fine.

 

As for the disappearing attachhose/removehose commands. Open up LAEquipmentCommands.script and delete all lines that involve those 2 commands.

I'll edit the model file and comment out the hose commands in the LA file, and see how it goes.

 

Edit: Yes, cannon is working now.

 

A quick question about the LA Brush Truck. If I set max connectors for those prototypes to 1 in the rapiddeployment script, will it work correctly?

 

Edit2: Ok, added attachfirehose to my people, and hovering over the vehicle brings up the icon and a click will activate, but the person just moves to near the back of the truck and nothing happens. Rapiddeployment also fails to work. Do the connector prototypes need to have a specific filename, or do the superstructs just need to have the connector name? For some reason the names did save on the connectors and they were named pump0-3. They connect now, though I have to add removefirehose to them still, but that should solve that problem.

 

Also, limitedwater doesn't seem to be working, at least with the cannon. The vehicle shows the waterlevel icon, so it gets the command added by the scripts, but the water never depletes and no message shows when I click on the command. That last seems to indicate it's not just a deal with it not recognizing the cannon.

[Hoppah]

A quick question about the LA Brush Truck. If I set max connectors for those prototypes to 1 in the rapiddeployment script, will it work correctly?

 

 

Also, limitedwater doesn't seem to be working, at least with the cannon. The vehicle shows the waterlevel icon, so it gets the command added by the scripts, but the water never depletes and no message shows when I click on the command. That last seems to indicate it's not just a deal with it not recognizing the cannon.

 

As for the brush truck, yes you will have to set the max to 1 in the script, just like it's kinda done in the older rapid deployment script.

 

Does the limited water at least work for the hose connections?

 

Can you post your edited scripts here? I'll take a quick look.

[The Loot]

Another thing about the brush truck. Since I've got a crew of two, how can it be worked so that they both get out, one hooks a hose while the other just connects a supply?

 

Also, is there a way to limit the amount of people who get out with rapiddeployment when you have less crew than hose connections? I've got my tender with three seats (since it isn't an extended cab), and 4 hose connections, but I'd like to keep the 3rd guy inside for the water cannon command.

 

So far, the water isn't working at all. Vehicles that get spawned on startup at least have the water level icon, but I sent more onto the map and they didn't get assigned that dummy.

 

Noticed this is my logfile for the startup, too. Something's amiss.

 

?Tried to assign unknown command 'DummyUpdateWaterLevel' to object U
?Tried to assign unknown command 'DummyUpdateWaterLevel' to object U
?Tried to assign unknown command 'DummyUpdateWaterLevel' to object U
?Tried to assign unknown command 'DummyUpdateWaterLevel' to object U
?Tried to assign unknown command 'DummyUpdateWaterLevel' to object U
?Tried to assign unknown command 'DummyUpdateWaterLevel' to object U
?Tried to assign unknown command 'DummyUpdateWaterLevel' to object U
?Tried to assign unknown command 'DummyUpdateWaterLevel' to object U
?Tried to assign unknown command 'DummyUpdateWaterLevel' to object U
!WATER, Start DummyCheckWaterSupply

 

Scripts here:  Command.rar   0bytes   47 downloads  fp_freeplay.rar   0bytes   37 downloads

 

Maybe my use of proto compares instead of vehicletype is messing up something?

 

Edit: Just noticed something. I don't have the correct file for "GameObject mDummy = Game::CreateObject("mod:Prototypes/06 Objects/Misc/empty.e4p", "WaterTankDummy");", though I noticed your test mod doesn't either and it worked. Added proto and corrected path, but no change.

[Hoppah]

Another thing about the brush truck. Since I've got a crew of two, how can it be worked so that they both get out, one hooks a hose while the other just connects a supply?

 

Also, is there a way to limit the amount of people who get out with rapiddeployment when you have less crew than hose connections? I've got my tender with three seats (since it isn't an extended cab), and 4 hose connections, but I'd like to keep the 3rd guy inside for the water cannon command.

 

So far, the water isn't working at all. Vehicles that get spawned on startup at least have the water level icon, but I sent more onto the map and they didn't get assigned that dummy.

 

Noticed this is my logfile for the startup, too. Something's amiss.

 

 

Scripts here: Command.rar fp_freeplay.rar

 

Maybe my use of proto compares instead of vehicletype is messing up something?

 

Edit: Just noticed something. I don't have the correct file for "GameObject mDummy = Game::CreateObject("mod:Prototypes/06 Objects/Misc/empty.e4p", "WaterTankDummy");", though I noticed your test mod doesn't either and it worked.

 

It says the command 'DummyUpdateWaterLevel' is unknown, so that probably means the commandscript cannot be loaded because of mistakes in it which are caused by your personal changes. However, I've taken a look at the script and noticed that there's at least missing symbols in the script.

 

 

Make sure to add a ; after the following 4 lines (lines 72-81 AND lines 208-217).

WaterLevel = MAX_WATER_TENDER

WaterLevel = MAX_WATER_LADDER

WaterLevel = MAX_WATER_ENGINE

WaterLevel = MAX_WATER_ENGINE2

You forgot to add that symbol in at least two locations in the script.

 

Other than that, the script seems to look good (I may have missed other things).

 

 

Hoppah

[The Loot]

Make sure to add a ; after the following 4 lines:

WaterLevel = MAX_WATER_TENDER

WaterLevel = MAX_WATER_LADDER

WaterLevel = MAX_WATER_ENGINE

WaterLevel = MAX_WATER_ENGINE2

 

Ah, missed that. Hopefully that will be it, or at least let me hit any other errors on the way.

 

Edit: Nope, no change, still the same errors in the log and nothing working. All missing semi-colons were added, so it's something else that isn't actually bringing up an error.

 WaterSupplyFreeplay.rar   0bytes   34 downloads

 

[Dyson]

My current position - absolutely everything works great, not using the deck gun at all, just deactivated it. The water supply works a treat. However my only bug is rapid deploy. The 4 guys get out, 3 hook up just fine, the 4th gets the hose, hooks it up fine, then gets the second hose, however he cant attatch, and has no attatch command.

 

Now personally Ithink I'd prefer him to just stay and monitor pump pressure so I may edit it myself, but just a heads up in case anyone else was having this issue me too

 

Awesome work Hop, this is another great addition to the world of Em4

[The Loot]

My current position - absolutely everything works great, not using the deck gun at all, just deactivated it. The water supply works a treat. However my only bug is rapid deploy. The 4 guys get out, 3 hook up just fine, the 4th gets the hose, hooks it up fine, then gets the second hose, however he cant attatch, and has no attatch command.

 

Man, if we aren't opposites... My rapiddeploy works flawlessly with the new hookups, but I've got a FUBAR watersupply.

 

My rapiddeployment script was attached a few posts back if you want to peek at it. But your idea for that last guy is kind of intriguing, though I think I'll keep mine as is.

[Dyson]

Haha, how peculiar? Whats up with your supply monitor? Mine works great although I'm not using the deck gun

 

Edit, having some issues trying to stop the 4th guy hooking up again after he adds the supply line. Any help would be appreciated, I'm guessing it's something to do with child 3 of the attatch firehose script, but I'm dumbfounded haha

[The Loot]

I think it's one of those pushactions that would control it. Comment out one of the lines and see what effect it has.

 

As for another problem of mine, my tender waterswitch doesn't want to work correctly. It activates and deactivates fine, but it won't extinguish or cool. I wonder if setting the cannon vehicle it creates to the LPF type instead of TLF is causing issues. I'd like the tender and my crash engines to have the more powerful deck gun so they have a difference between the regular engines.

 

And Hoppah, since you were asking for a water supply truck for use with some vehicle to vehicle supply functionality in the future, Freakinmusket did make one for his LA County submod.

[Dyson]

I think it's one of those pushactions that would control it. Comment out one of the lines and see what effect it has.

 

Yeah gonna have to just blindly delete pushactions and hope for the best haha, I'll see how it goes